errose28 commented on code in PR #10028:
URL: https://github.com/apache/ozone/pull/10028#discussion_r3053866070


##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/rolling-upgrade/driver.sh:
##########


Review Comment:
   I think we need a `wait_for_port` check for `s3g{1..3}`. Hypothetically all 
the s3 gateways could be restarted faster than their individual ports are 
active after restart and they would all be offline for a period of time.



##########
hadoop-ozone/dist/src/main/compose/testlib.sh:
##########
@@ -278,7 +278,7 @@ reorder_om_nodes() {
         "if [[ -f /etc/hadoop/ozone-site.xml ]]; then \
           sed -i -e 's/om1,om2,om3/${new_order}/' /etc/hadoop/ozone-site.xml; \
           echo 'Replaced OM order with ${new_order} in ${c}'; \
-        fi"
+        fi" || true

Review Comment:
   Can we do this differerently? For example:
   - Exclude haproxy containers from the loop
   - Check if `/etc/hadoop/ozone-site.xml` exists in the container using `sh` 
before invoking `bash`
   - Reformat this to use `sh`
   - Switch to the [debian based haproxy 
image](https://hub.docker.com/layers/library/haproxy/lts/images/sha256-fa4e4f6ac7520c51c3ac71b583ba3d95a99a9572e0019638b42b507fbc452b2d)
 (30mb larger)
   
   If we do want to use the current solution let's add a comment explaining it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to