adoroszlai commented on code in PR #10056:
URL: https://github.com/apache/ozone/pull/10056#discussion_r3044620503
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -313,7 +316,8 @@ public String getNamespace() {
.register(OZONE_BLOCK_DELETING_SERVICE_TIMEOUT,
this::reconfigBlockDeletingServiceTimeout)
.register(REPLICATION_STREAMS_LIMIT_KEY,
- this::reconfigReplicationStreamsLimit);
+ this::reconfigReplicationStreamsLimit)
+ .register(tracingConfig);
Review Comment:
nit: please move this `.register` call (and the one in SCM) to the first
place in the chain to reduce the diff (due to moving `;`) -- i.e. make it
similar to `OzoneManager`.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -253,8 +255,9 @@ public String getNamespace() {
datanodeDetails.setSetupTime(Time.now());
datanodeDetails.setRevision(
HddsVersionInfo.HDDS_VERSION_INFO.getRevision());
- TracingUtil.initTracing(
- "HddsDatanodeService." + datanodeDetails.getID(), conf);
+ tracingServiceName = "HddsDatanodeService." + datanodeDetails.getID();
+ TracingConfig tracingConfig = conf.getObject(TracingConfig.class);
+ TracingUtil.initTracing(tracingServiceName, conf);
Review Comment:
Since we have `TracingConfig` instance here, please pass it to `initTracing`
instead of `ConfigurationSource`.
Also, `initTracing` could return a stateful object that
- stores name and `TracingConfig` so they do not need to be passed to
`reconfigureTracing`
- can be used as a `ReconfigurationChangeCallback` so we don't need to
duplicate code for creating anonymous implementations in each service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
