ptlrs commented on code in PR #9813:
URL: https://github.com/apache/ozone/pull/9813#discussion_r3076159654
##########
hadoop-hdds/rocks-native/src/main/patches/rocks-native.patch:
##########
@@ -380,9 +381,9 @@ index 000000000..5ba8a82ee
+
+ rep_->file_.reset(new RandomAccessFileReader(std::move(file), file_path));
+
-+ FilePrefetchBuffer prefetch_buffer(
-+ 0 /* readahead_size */, 0 /* max_readahead_size */, true /* enable */,
-+ false /* track_min_offset */);
++ FilePrefetchBuffer prefetch_buffer(ReadaheadParams(),
++ !fopts.use_mmap_reads /* enable */,
++ false /* track_min_offset */);
+ if (s.ok()) {
Review Comment:
Do we know where the `raw_sst_file_reader` header and implementation files
are located?
This
[comment](https://github.com/apache/ozone/pull/6182#discussion_r1498510016)
mentions that the implementation was originally copied from `sst_file_dumper`
but that file doesn't seem to show any signature changes for `prefetch_buffer`
in `10.10.1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
