smengcl commented on PR #9813: URL: https://github.com/apache/ozone/pull/9813#issuecomment-4284435025
> > Since RocksDB 9, BlockBasedTableOptions.format_version=6 is the default. Files written in format_version 6 cannot be read by RocksDB < 8.6.0. This PR explicitly sets the default to version 5 to be compatible with 7.7.3 in the case where Ozone gets downgraded before it gets finalized after an upgrade. ref: [facebook/rocksdb@`v9.0.0` (release)](https://github.com/facebook/rocksdb/releases/tag/v9.0.0) > > Can we explore what it would take to support the newer file formats? What are the challenges with the following and other potential solutions: > > * For a fresh installation, we could use the newer format by default. > * For an upgrade scenario, we could consider re-ingesting the SST files. @ptlrs We surely can add a post finalization step to reingest the SST files, but there is no official tool iirc to do such in-place reingestion so basically it is up to us to write the logic to read from old SSTs and write to new ones. Or, just allow new SST files to be written in format_version=6 post finalization. Old SSTs should get compacted into new format_version=6 SSTs eventually. I'd prefer the latter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
