sodonnel commented on code in PR #10084:
URL: https://github.com/apache/ozone/pull/10084#discussion_r3099273005


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1168,6 +1168,28 @@ public HddsProtos.UpgradeStatus queryUpgradeStatus() 
throws IOException {
     }
   }
 
+  static HddsProtos.UpgradeStatus buildUpgradeStatus(
+      UpgradeFinalization.Status scmUpgradeStatus,
+      int finalizedDatanodes,
+      int totalDatanodes) {
+    return HddsProtos.UpgradeStatus.newBuilder()
+        .setScmFinalized(isScmFinalized(scmUpgradeStatus))
+        .setNumDatanodesFinalized(finalizedDatanodes)
+        .setNumDatanodesTotal(totalDatanodes)
+        .setShouldFinalize(shouldFinalize(scmUpgradeStatus))
+        .build();
+  }
+
+  static boolean isScmFinalized(UpgradeFinalization.Status scmUpgradeStatus) {
+    return UpgradeFinalization.isFinalized(scmUpgradeStatus)
+        || UpgradeFinalization.isDone(scmUpgradeStatus);
+  }
+
+  static boolean shouldFinalize(UpgradeFinalization.Status scmUpgradeStatus) {

Review Comment:
   I am not sure about this - the shouldFinalize boolean is to instruct other 
components to finalize when SCM AND the datanodes are done finalizing. So this 
should be true only if SCM is finalized and all DNs are finalized. The idea is 
that OM will poll this when OM is unfinalized and it will automatically 
finalize when this goes true. So I think we need to check `num_dns == 
finalizated_dns && scm == finalized`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to