sodonnel commented on code in PR #10084:
URL: https://github.com/apache/ozone/pull/10084#discussion_r3099280848


##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java:
##########
@@ -737,6 +737,37 @@ public void testProcessLayoutVersion() throws IOException {
     testProcessLayoutVersionReportHigherMlv();
   }
 
+  @Test

Review Comment:
   I think we need a test for registration when a DN is finalized on 
registration, and not finalized on registration and when the remove_node is 
called too. This test covers the heartbeat part I think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to