rakeshadr commented on PR #10074: URL: https://github.com/apache/ozone/pull/10074#issuecomment-4303242076
Thanks a lot @ashishkumar50 for the detailed explanation and continuous efforts in handling this. **General comments:** 1) IIUC, `Full snapshot` is a costly operation and the cost vary depends on the SCM database size, I'd suggest `not to trigger automatic FULL_SNAP `instead analyze the overhead of snapshot datatransfer, snapshot loading, GC Pressure & potential system resource utilization based on existing known SCM database size(say if the database size is 275GB and 300M containers). Then will think about the solution and proposal to the users. 2) Could you please come up with the set of meaningful metrics to understand the TARGETED_SYNC. For example, per state based metrics which can be used by the users/customers to determine the nonOpenDrift acceptable discrepancies and tune the TARGETED_SYNC interval. Another one can be the time taken etc. 3) Can we think of a warning or alert if the decrecepencies grows beyond certain threshold or limit? Something like, non_open_container_decrecepencies <= 10K and the TARGETED_SYNC interval is 1hr ``` Apr 22nd 00:01 AM : non_open_container_decrecepencies 10K Apr 22nd 00:02 AM : non_open_container_decrecepencies 5K Apr 22nd 00:03 AM : non_open_container_decrecepencies 15K WARN Apr 22nd 00:04 AM : non_open_container_decrecepencies 12K WARN Apr 22nd 00:05 AM : non_open_container_decrecepencies 2K Apr 22nd 00:06 AM : non_open_container_decrecepencies 2K Apr 22nd 00:07 AM : non_open_container_decrecepencies 2K ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
