[ 
https://issues.apache.org/jira/browse/HDDS-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishabh Patel updated HDDS-15114:
---------------------------------
    Description: 
Some threadpools are misconfigured and the effective number of threads remains 
low. 

One such example is in 
[TarExtractor|https://github.com/apache/ozone/blob/56b5b0231760013cf614725738c5eaf3d9bac840/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/TarExtractor.java#L164-L169]
{code:java}
new ThreadPoolExecutor(0, threadPoolSize, 60L, TimeUnit.SECONDS, new 
LinkedBlockingQueue<>(), threadFactory); {code}
Here the number of threads in the threadpool will always be one. 

 

Some classes like ReplicationSupervisor use the ExecutorService interface when 
they actually need access to the internal ThreadPoolExecutor and resort to 
unnecessary casting. 

 

Others like XceiverServerGrpc, GrpcOzoneManagerServer, TrashPolicyOzone, 
ReplicationServer use the ThreadPoolExecutor, when they could use a wider 
ExecutorService type. 

  was:
Some threadpools are misconfigured and the effective number of threads remains 
low. 

One such example is in 
[TarExtractor|https://github.com/apache/ozone/blob/56b5b0231760013cf614725738c5eaf3d9bac840/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/TarExtractor.java#L164-L169]

 
{code:java}
new ThreadPoolExecutor(0, threadPoolSize, 60L, TimeUnit.SECONDS, new 
LinkedBlockingQueue<>(), threadFactory); {code}

Here the number of threads in the threadpool will always be one. 

 


> Fix misconfigured threadpools
> -----------------------------
>
>                 Key: HDDS-15114
>                 URL: https://issues.apache.org/jira/browse/HDDS-15114
>             Project: Apache Ozone
>          Issue Type: Bug
>            Reporter: Rishabh Patel
>            Assignee: Rishabh Patel
>            Priority: Major
>
> Some threadpools are misconfigured and the effective number of threads 
> remains low. 
> One such example is in 
> [TarExtractor|https://github.com/apache/ozone/blob/56b5b0231760013cf614725738c5eaf3d9bac840/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/TarExtractor.java#L164-L169]
> {code:java}
> new ThreadPoolExecutor(0, threadPoolSize, 60L, TimeUnit.SECONDS, new 
> LinkedBlockingQueue<>(), threadFactory); {code}
> Here the number of threads in the threadpool will always be one. 
>  
> Some classes like ReplicationSupervisor use the ExecutorService interface 
> when they actually need access to the internal ThreadPoolExecutor and resort 
> to unnecessary casting. 
>  
> Others like XceiverServerGrpc, GrpcOzoneManagerServer, TrashPolicyOzone, 
> ReplicationServer use the ThreadPoolExecutor, when they could use a wider 
> ExecutorService type. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to