aryangupta1998 commented on code in PR #10125:
URL: https://github.com/apache/ozone/pull/10125#discussion_r3150112296
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -175,7 +175,8 @@ public DirectoryDeletingService(long interval, TimeUnit
unit,
OMConfigKeys.OZONE_OM_RATIS_LOG_APPENDER_QUEUE_BYTE_LIMIT_DEFAULT,
StorageUnit.BYTES);
this.numberOfParallelThreadsPerStore = dirDeletingServiceCorePoolSize;
- this.deletionThreadPool = new ThreadPoolExecutor(0,
numberOfParallelThreadsPerStore,
+ this.deletionThreadPool = new ThreadPoolExecutor(
+ numberOfParallelThreadsPerStore, numberOfParallelThreadsPerStore,
Review Comment:
In our pool, keep-alive is sourced from super.getIntervalMillis(). If that
value is 0 ms (or resolves to 0 after config conversion), calling
allowCoreThreadTimeOut(true) can throw an IllegalArgumentException during pool
creation/startup. So I have added a guard rail as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
