fmorg-git commented on code in PR #9971:
URL: https://github.com/apache/ozone/pull/9971#discussion_r3156211525
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4057,15 +4065,24 @@ public OmMultipartUploadList
listMultipartUploads(String volumeName,
String prefix, String keyMarker, String uploadIdMarker, int maxUploads,
boolean withPagination)
throws IOException {
- ResolvedBucket bucket = resolveBucketLink(Pair.of(volumeName, bucketName));
+ final ResolvedBucket bucket = resolveBucketLink(Pair.of(volumeName,
bucketName));
+ final String realVolumeName = bucket.realVolume();
+ final String realBucketName = bucket.realBucket();
- Map<String, String> auditMap = bucket.audit();
+ final Map<String, String> auditMap = bucket.audit();
auditMap.put(OzoneConsts.PREFIX, prefix);
- metrics.incNumListMultipartUploads();
try {
- OmMultipartUploadList omMultipartUploadList =
keyManager.listMultipartUploads(bucket.realVolume(),
- bucket.realBucket(), prefix, keyMarker, uploadIdMarker, maxUploads,
withPagination);
+ if (getAclsEnabled() && isStsS3Request()) {
Review Comment:
ideally yes, but since it was not there initially, I don't know who or how
many people it would break if it were added for normal s3 request. Should that
be a separate Jira to investigate that so it doesn't seem like STS broke
"normal" s3 functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
