fmorg-git commented on code in PR #9971:
URL: https://github.com/apache/ozone/pull/9971#discussion_r3156211525
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4057,15 +4065,24 @@ public OmMultipartUploadList
listMultipartUploads(String volumeName,
String prefix, String keyMarker, String uploadIdMarker, int maxUploads,
boolean withPagination)
throws IOException {
- ResolvedBucket bucket = resolveBucketLink(Pair.of(volumeName, bucketName));
+ final ResolvedBucket bucket = resolveBucketLink(Pair.of(volumeName,
bucketName));
+ final String realVolumeName = bucket.realVolume();
+ final String realBucketName = bucket.realBucket();
- Map<String, String> auditMap = bucket.audit();
+ final Map<String, String> auditMap = bucket.audit();
auditMap.put(OzoneConsts.PREFIX, prefix);
- metrics.incNumListMultipartUploads();
try {
- OmMultipartUploadList omMultipartUploadList =
keyManager.listMultipartUploads(bucket.realVolume(),
- bucket.realBucket(), prefix, keyMarker, uploadIdMarker, maxUploads,
withPagination);
+ if (getAclsEnabled() && isStsS3Request()) {
Review Comment:
yes, discussed with others and they agreed (initially I was concerned it
would break existing users, but this check needs to be there in any case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
