sodonnel commented on code in PR #10152:
URL: https://github.com/apache/ozone/pull/10152#discussion_r3160192529
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java:
##########
@@ -115,6 +115,23 @@ public StatusAndMessages finalize(String upgradeClientID,
T service)
}
}
+ @Override
+ public void finalize(T service) throws IOException {
+ UpgradeFinalization.Status status = versionManager.getUpgradeState();
+ if (isFinalized(status)) {
+ return;
+ }
+ try {
+ if (status == FINALIZATION_REQUIRED) {
+ finalizationExecutor.execute(service, this);
+ }
+ } catch (NotLeaderException e) {
Review Comment:
I guess it won't propagate back with the catch block in place, so I think we
should re-throw after the log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
