sodonnel commented on code in PR #10152:
URL: https://github.com/apache/ozone/pull/10152#discussion_r3160253711
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestHddsUpgradeUtils.java:
##########
@@ -50,16 +49,16 @@ public final class TestHddsUpgradeUtils {
private TestHddsUpgradeUtils() { }
+ // This is currently testing that the SCM and datanode side finalization is
complete.
+ // TODO - should this test for SCM and DNs and OM?
public static void waitForFinalizationFromClient(
Review Comment:
The only slight problem is that `LambdaTestUtils.await` is in the test
package, so it will not be accessible outside of test scope. Also in the tests,
we would want to timeout, but in the client it may want to wait forever.
Maybe the criteria for finalize being complete should be moved out of here?
Then the client would just poll in a loop with a sleep, while the test code can
use the lambda util to get a timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
