slfan1989 opened a new pull request, #10187:
URL: https://github.com/apache/ozone/pull/10187
## What changes were proposed in this pull request?
This PR improves validation coverage for the Ozone Iceberg
`RewriteTablePath` action and replaces direct console output with SLF4J logging.
The Ozone Iceberg `RewriteTablePathOzoneAction` already validates several
user-provided inputs, such as source/target prefixes and metadata version
names. However, some validation paths were not covered by unit tests. In
particular, executing the action without configuring the source and target
prefixes previously resulted in a raw JVM `NullPointerException` message
instead of the existing validation helper's clearer error message.
This PR proposes the following changes:
* Add unit tests for invalid `RewriteTablePathOzoneAction` inputs:
* missing source/target location prefix
* identical source and target prefixes
* unknown start metadata version
* unknown end metadata version
* Add explicit validation for missing source and target prefixes in
`execute()`.
* Replace a direct `System.out.println` call in
`RewriteTablePathOzoneAction` with SLF4J logging.
These changes make the Iceberg rewrite path action easier to validate and
keep logging consistent with the rest of the Ozone codebase.
## What is the link to the Apache JIRA
HDDS-15172. Add validation tests and logging cleanup for Ozone Iceberg
RewriteTablePath action.
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests,
workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
