YutaLin commented on code in PR #10207:
URL: https://github.com/apache/ozone/pull/10207#discussion_r3212484881


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3ConditionalRequest.java:
##########
@@ -45,80 +45,92 @@ final class S3ConditionalRequest {
   private S3ConditionalRequest() {
   }
 
-  static Response evaluateReadPreconditions(HttpHeaders headers,
-      String keyPath, OzoneKey key) throws OS3Exception {
+  /**
+   * Context for evaluating preconditions, defining which headers to check
+   * and how to handle cache validation scenarios.
+   */
+  enum PreconditionContext {

Review Comment:
   All write operations use the same headers and have the same behavior:
     - If-None-Match: * → create only if key doesn't exist
     - If-Match: <etag> → overwrite only if ETag matches
     - Both throw 412 on failure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to