peterxcli commented on code in PR #10207:
URL: https://github.com/apache/ozone/pull/10207#discussion_r3213008925
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3ConditionalRequest.java:
##########
@@ -45,80 +45,92 @@ final class S3ConditionalRequest {
private S3ConditionalRequest() {
}
- static Response evaluateReadPreconditions(HttpHeaders headers,
- String keyPath, OzoneKey key) throws OS3Exception {
+ /**
+ * Context for evaluating preconditions, defining which headers to check
+ * and how to handle cache validation scenarios.
+ */
+ enum PreconditionContext {
Review Comment:
oh, I got your point, write header are always the same, this class is only
for distinguishing the copy/read request header(they have same suffix)
However the `PreconditionContext` name is too generic, let's rename it to
sth like ReadCondition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
