adoroszlai commented on code in PR #10239:
URL: https://github.com/apache/ozone/pull/10239#discussion_r3223905753
##########
hadoop-ozone/dist/src/main/compose/ozonesecure/docker-compose.yaml:
##########
@@ -14,6 +14,18 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# reusable fragments
+x-common-config:
+ &common-config
+ image: ${OZONE_RUNNER_IMAGE}:${OZONE_RUNNER_VERSION}
+ dns_search: .
+ volumes:
+ - ../..:/opt/hadoop
+ - ../_keytabs:/etc/security/keytabs
+ - ./krb5.conf:/etc/krb5.conf
+ env_file:
+ - docker-config
Review Comment:
`./` is required for `volumes` in the current directory ("to avoid
ambiguities with named volumes, relative paths should always begin with . or
.."). There is no such ambiguity with `env_file`, so the form `docker-config`
is recommended for simplicity.
https://docs.docker.com/reference/compose-file/services/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
