navinko commented on code in PR #10211: URL: https://github.com/apache/ozone/pull/10211#discussion_r3244078069
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SequenceIdType.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.ha; + +/** + * Represents the sequence ID types managed by {@link SequenceIdGenerator} and their persisted RocksDB keys. + */ +public enum SequenceIdType { Review Comment: Thanks @szetszwo I just updated the changes ,tried incorporating the suggestions. - used enum constants same as db key - refactored related code ,test cases and updated required comments . - tested with existing and updated test cases .ran locally with docker secure cluster and verified allocation paths and updated under "How was this patch tested" - CI build progressing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
