sreejasahithi commented on code in PR #10306:
URL: https://github.com/apache/ozone/pull/10306#discussion_r3280533213


##########
hadoop-ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java:
##########
@@ -255,6 +268,13 @@ private String rebuildMetadata() {
     RewriteContentFileResult rewriteManifestResult =
         rewriteManifests(deltaSnapshotIds, endMetadata, 
rewriteManifestListResult.toRewrite());
 
+    Set<DeleteFile> deleteFiles =
+        rewriteManifestResult.toRewrite().stream()
+            .filter(e -> e instanceof DeleteFile)
+            .map(e -> (DeleteFile) e)
+            .collect(Collectors.toSet());
+    rewritePositionDeletes(deleteFiles);

Review Comment:
   Currently we are supporting Iceberg version 1.10.1 in Ozone.
   Iceberg has added the capability to rewrite deletion vector files and 
partition statistics files in iceberg version 1.11.0 
   so when we support 1.11.0 in ozone then we can look forward to support those 
file rewrites as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to