peterxcli commented on code in PR #10306:
URL: https://github.com/apache/ozone/pull/10306#discussion_r3268735742
##########
hadoop-ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java:
##########
@@ -255,6 +268,13 @@ private String rebuildMetadata() {
RewriteContentFileResult rewriteManifestResult =
rewriteManifests(deltaSnapshotIds, endMetadata,
rewriteManifestListResult.toRewrite());
+ Set<DeleteFile> deleteFiles =
+ rewriteManifestResult.toRewrite().stream()
+ .filter(e -> e instanceof DeleteFile)
+ .map(e -> (DeleteFile) e)
+ .collect(Collectors.toSet());
+ rewritePositionDeletes(deleteFiles);
Review Comment:
Should we rewrite deletion vector puffin files? I think if users are using
V3 then they need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
