szetszwo commented on code in PR #10181:
URL: https://github.com/apache/ozone/pull/10181#discussion_r3290300974
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java:
##########
@@ -243,9 +243,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, Execut
Map<String, RepeatedOmKeyInfo> oldKeyVersionsToDeleteMap = null;
validateAtomicRewrite(keyToDelete, omKeyInfo, auditMap);
- // Optimistic locking validation has passed. Now set the rewrite fields
to null so they are
- // not persisted in the key table.
- omKeyInfo.setExpectedDataGeneration(null);
Review Comment:
In OmKeyInfo,
- remove the setExpectedDataGeneration(..) method and
- add final to expectedDataGeneration.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -59,8 +59,13 @@ public final class OmKeyInfo extends WithParentObjectId
implements CopyObject<OmKeyInfo>, WithTags {
private static final Logger LOG = LoggerFactory.getLogger(OmKeyInfo.class);
- private static final Codec<OmKeyInfo> CODEC_TRUE = newCodec(true);
- private static final Codec<OmKeyInfo> CODEC_FALSE = newCodec(false);
+ // Codecs for openKeyTable
+ private static final Codec<OmKeyInfo> CODEC_TRUE = newCodec(true, true);
+ private static final Codec<OmKeyInfo> CODEC_FALSE = newCodec(false, true);
+
+ // Codecs for keyTable
+ private static final Codec<OmKeyInfo> CODEC_KEY_TABLE_TRUE = newCodec(true,
false);
+ private static final Codec<OmKeyInfo> CODEC_KEY_TABLE_FALSE =
newCodec(false, false);
Review Comment:
Just found that `ignorePipeline` is always true except for tests. Let's
remove it first before making this change. Filed HDDS-15349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
