ivandika3 commented on PR #10170: URL: https://github.com/apache/ozone/pull/10170#issuecomment-4375846720
@YutaLin The new OpenKeyInfo proto and KeyInfo proto are not compatible. For example, the field 1 for `OpenKeyInfo` is a `KeyInfo`, but field 1 for `KeyInfo` is volumeName. This means it's not backward and forward compatible. > Would it be acceptable to implement a backward compatible codec that first attempts to serialize OpenKeyInfo and falls back to KeyInfo if that attempt fails? No I don't think so, duplicate codec serde might cause performance issues since openKeyTable & openFileTable is in the critical path. I think the approach in https://github.com/apache/ozone/pull/10181 might be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
