arunsarin85 opened a new pull request, #10363: URL: https://github.com/apache/ozone/pull/10363
## What changes were proposed in this pull request? - Wait until inflight compactions are drained before assertions that depend on a complete compaction DAG. - Stop using hard-coded SST id lists for diff expectations: derive the baseline diff per run via getSSTDiffList with the full column-family mask, then apply the same subset filtering as before; compare sorted file names to avoid ordering noise. - Column-family resolution for filtering: resolve from the compaction DAG or snapshot metadata; ignore SST ids that are not present on this run when building expectations (so golden lists don’t fight varying RocksDB numbering). - SST backup directory check: replace fixed .sst filenames with assertions on count, .sst suffix, and membership in getCompactionNodeMap() (and fix the reversed “expected vs actual” comparison that used the directory listing as “expected”). Please describe your PR in detail: TestRocksDBCheckpointDiffer#testDifferWithDB was flaky on CI because RocksDB does not always assign the same SST file numbers or compaction shape across runs and OSes. The test mixed timing (DAG not fully updated), hard-coded SST names for diff expectations and for SST backup links, and a misleading backup assertion where the filesystem listing was passed as expected and compared to a static list. This change makes the test derive what it can from the same code under test (getSSTDiffList, compaction node map, backup dir contents) instead of pinning to one successful run’s numeric ids. It keeps the intent: compaction tracking runs, DAG-based diffs behave consistently across column-family subsets, and compaction-input backups exist and correspond to tracked SSTs. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-15209 ## How was this patch tested? flaky-test-check workflow with submodule=rocksdb-checkpoint-differ, test-class=org.apache.ozone.rocksdiff.TestRocksDBCheckpointDiffer, test-name=testDifferWithDB https://github.com/arunsarin85/ozone/actions/runs/26268683979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
