peterxcli commented on code in PR #10362:
URL: https://github.com/apache/ozone/pull/10362#discussion_r3307746351
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestContainerSmallFile.java:
##########
Review Comment:
Should we add some storage type test here, too?
sine there is a branch `HddsDispatcher#createContainer`
```java
if (containerRequest.hasPutSmallFile()) {
// PutSmallFile Not support EC yet
DatanodeBlockID blockID =
containerRequest.getPutSmallFile().getBlock().getBlockData().getBlockID();
if (blockID.hasStorageTypeID() && blockID.getStorageTypeID() > 0) {
createRequest.setStorageTypeID(blockID.getStorageTypeID());
}
}
```
or maybe it's easier to add the small file container create test in
`TestHddsDispatcher`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
