xichen01 commented on PR #10362: URL: https://github.com/apache/ozone/pull/10362#issuecomment-4553554786
> Thanks @xichen01 for the patch. I think we should keep the old method in `VolumeChoosingPolicy` and mark it as `@Deprecated`(for users who might have custom VolumeChoosingPolicy implementations). @chungen0126 I kept only one `VolumeChoosingPolicy` that includes the `StorageType` parameter so that the caller of `chooseVolume` is explicitly aware of the `StorageType` parameter. This helps prevent any oversights. If there are other custom `VolumeChoosingPolicy` implementations, they should also take the `StorageType` parameter into account. For existing implementations such as `CapacityVolumeChoosingPolicy` and `RoundRobinVolumeChoosingPolicy`, `AbstractStorageTypeChoosingPolicy#chooseVolumeInternal` is currently overridden. If you have a custom `VolumeChoosingPolicy`, you can also refer to this implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
