Copilot commented on code in PR #10209:
URL: https://github.com/apache/ozone/pull/10209#discussion_r3352605158
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -1264,14 +1284,16 @@ private static FileStatusAdapter
getFileStatusAdapterWithSnapshotIndicator(
ozoneBucket.getName(), pathStr);
}
Path path = new Path(pathStr);
+ ReplicationConfig rc = ozoneBucket.getReplicationConfig();
+ boolean isEc = rc != null && rc.getReplicationType() ==
HddsProtos.ReplicationType.EC;
+ String ecPolicy = isEc ? rc.getReplication() : "";
Review Comment:
The snapshot-indicator (the synthetic `.snapshot` directory) is currently
inheriting the bucket’s EC policy via `ozoneBucket.getReplicationConfig()`. The
PR description says snapshot indicators should report an empty EC-policy (""),
and since this is not a real key/directory it shouldn’t advertise the bucket’s
replication policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
