amaliujia commented on code in PR #10408:
URL: https://github.com/apache/ozone/pull/10408#discussion_r3356637136
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/RootEndpoint.java:
##########
@@ -48,6 +58,101 @@ public class RootEndpoint extends EndpointBase {
@GET
public Response get()
throws OS3Exception, IOException {
+ if (isListDirectoryBucketsRequest()) {
Review Comment:
So when all the parameters are optional, seems that the code eventually will
fall back to ListAllBuckets.
Is it possible that the request is a `ListDirectoryBuckets` without a
parameters and `isS3ExpressSignedRequest` is also false? If this is possible,
then a `ListDirectoryBuckets` would be converted to `ListAllBuckets` which does
not sound right.
However if the scenario above is not legit, then here the `if return ?else
return` is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
