navinko commented on code in PR #10405:
URL: https://github.com/apache/ozone/pull/10405#discussion_r3358625761
##########
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot:
##########
@@ -160,7 +160,7 @@ Get All Container IDs
Get Datanode Ozone Used Bytes Info
[arguments] ${uuid}
- ${output} = Execute export DATANODES=$(ozone admin datanode list
--json) && for datanode in $(echo "$\{DATANODES\}" | jq -r '.[].id'); do ozone
admin datanode usageinfo --uuid=$\{datanode\} --json | jq
'{(.[0].datanodeDetails.id.uuid) : .[0].ozoneUsed}'; done | jq -s add
+ ${output} = Execute export DATANODES=$(ozone admin datanode list
--json) && for datanode in $(echo "$\{DATANODES\}" | jq -r '.[].id'); do ozone
admin datanode usageinfo --uuid=$\{datanode\} --json | jq
'{(.[0].datanodeDetails.uuidString) : .[0].ozoneUsed}'; done | jq -s add
Review Comment:
Hi @szetszwo
If we keep DatanodeID.getUuid() it pass the robot test.
Since the DatanodeID#getUuid () which was returning UUID was deprecated one
and is already removed , the DatanodeID.getUuid() we been using return String
only .
CI build successsful :
https://github.com/navinko/ozone/actions/runs/26967483156
In master looks like some env issue causing test failure .
Below is the datanodeDetails obj for 'ozone admin datanode usageinfo' o/p
json in our patch now vs master.
>
### After fixing unintentional merge on conflict resolution and used
DatanodeID#getUuid() returning string
"datanodeDetails" : {
"level" : 3,
"cost" : 0,
"id" : {
"uuid" : "760f1a0c-cdc8-40af-a179-516714de969a",
"byteString" : {
"validUtf8" : true,
"empty" : false
}
}
# From current master branch
"datanodeDetails" : {
"level" : 3,
"cost" : 0,
"id" : {
"uuid" : "a643947e-407e-4e06-9b3a-dd6c779dab73",
"id" : "a643947e-407e-4e06-9b3a-dd6c779dab73",
"byteString" : {
"validUtf8" : true,
"empty" : false
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
