navinko commented on code in PR #10405:
URL: https://github.com/apache/ozone/pull/10405#discussion_r3350574766
##########
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot:
##########
@@ -160,7 +160,7 @@ Get All Container IDs
Get Datanode Ozone Used Bytes Info
[arguments] ${uuid}
- ${output} = Execute export DATANODES=$(ozone admin datanode list
--json) && for datanode in $(echo "$\{DATANODES\}" | jq -r '.[].id'); do ozone
admin datanode usageinfo --uuid=$\{datanode\} --json | jq
'{(.[0].datanodeDetails.id.uuid) : .[0].ozoneUsed}'; done | jq -s add
+ ${output} = Execute export DATANODES=$(ozone admin datanode list
--json) && for datanode in $(echo "$\{DATANODES\}" | jq -r '.[].id'); do ozone
admin datanode usageinfo --uuid=$\{datanode\} --json | jq
'{(.[0].datanodeDetails.uuidString) : .[0].ozoneUsed}'; done | jq -s add
Review Comment:
Hi @szetszwo, Agreed we should not change the contract . DatanodeID exposes
a field uuid and there was a getter for that which was being referred when
robot test output jq '{(.[0].datanodeDetails.id.uuid getting evaluated , it
look for getUuid() which we renamed to getUuidStringForTesting
https://github.com/apache/ozone/pull/10405/changes/f2c0076782a37da8878620dae0196e845068e2f8#diff-e17218a6afd5c74990ac51dca37ce4654df8d2f38ed3bb6c56b2ba608893894eR47-L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
