sreejasahithi commented on code in PR #10409:
URL: https://github.com/apache/ozone/pull/10409#discussion_r3360677272
##########
hadoop-ozone/dist/pom.xml:
##########
@@ -37,6 +37,8 @@
<docker.ozone.image.flavor>-rocky</docker.ozone.image.flavor>
<downloadSources>true</downloadSources>
<file.encoding>UTF-8</file.encoding>
+ <!-- ozone-iceberg is built only with JDK 11+, dist matches that via
jdk11-with-iceberg profile -->
+ <include.iceberg>false</include.iceberg>
Review Comment:
Thanks for the suggestion, but I would like to keep a single include.iceberg
flag here.
Both places in dist-layout-stitching (classpath + jar copy) need the same
yes/no, and that already tracks the jdk11-with-iceberg profile (false on JDK 8,
true on JDK 11+). Two properties would mostly duplicate one boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
