adoroszlai commented on code in PR #10409:
URL: https://github.com/apache/ozone/pull/10409#discussion_r3361917325
##########
hadoop-ozone/dist/dev-support/bin/dist-layout-stitching:
##########
@@ -132,12 +134,23 @@ run mkdir compose/_keytabs
for file in $(find "${ROOT}" -path '*/target/classes/*.classpath' | sort); do
# We need to add the artifact manually as it's not part the generated
classpath desciptor
module=$(basename "${file%.classpath}")
+ if [[ "${INCLUDE_ICEBERG}" != "true" && "${module}" == "ozone-iceberg" ]];
then
+ continue
+ fi
Review Comment:
I don't think we need any change in `dist-layout-stitching`, nor
corresponding changes in `pom.xml`. If the module is not built, we will not
find generated `.classpath` file or jars in `target`.
##########
hadoop-ozone/iceberg/src/main/java/org/apache/hadoop/ozone/iceberg/RewriteTablePathOzoneAction.java:
##########
@@ -96,7 +96,7 @@ public class RewriteTablePathOzoneAction implements
RewriteTablePath {
private String startVersionName;
private String endVersionName;
private String stagingDir;
- private int parallelism;
+ private int threads;
Review Comment:
It's not necessary to match CLI, if you want to keep the original name. OK
either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
