greenwich commented on code in PR #10410:
URL: https://github.com/apache/ozone/pull/10410#discussion_r3360774862
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManagerUtil.java:
##########
@@ -71,22 +72,24 @@ private static String
formatDatanodeDetails(List<DatanodeDetails> dns) {
* policy will be called again. This will continue until the placement policy
* is able to select enough nodes or the number of nodes requested is reduced
* to zero when an exception will be thrown.
- * @param policy The placement policy to use to select nodes.
- * @param requiredNodes The number of nodes required
- * @param usedNodes Any nodes already used by the container
- * @param excludedNodes Any Excluded nodes which cannot be selected
+ *
+ * @param policy The placement policy to use to select nodes.
+ * @param requiredNodes The number of nodes required
+ * @param usedNodes Any nodes already used by the container
+ * @param excludedNodes Any Excluded nodes which cannot be selected
* @param defaultContainerSize The cluster default max container size
- * @param container The container to select new replicas for
+ * @param container The container to select new replicas for
+ * @param storageType
Review Comment:
nit: empty `storageType` param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
