xichen01 commented on code in PR #10410:
URL: https://github.com/apache/ozone/pull/10410#discussion_r3382186315
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/StorageTier.java:
##########
@@ -40,21 +37,23 @@ public enum StorageTier {
private final String tierName;
private final List<StorageType> storageTypes;
- private final boolean uniformStorageType;
- private static final Map<StorageTier, Map<ReplicationConfig,
List<StorageType>>>
+ private final boolean isUniform;
+ private static final Map<StorageTier, Map<Integer, List<StorageType>>>
CACHE = new EnumMap<>(StorageTier.class);
+ public static final int MAX_NODE_COUNT = 20;
Review Comment:
This was intended to accommodate non-uniform storage tiers, which is why the
cache and subsequent `computeId` were added. Looking at the current code, this
seems like overengineering.
Let me simplify this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
