ivandika3 commented on code in PR #10408:
URL: https://github.com/apache/ozone/pull/10408#discussion_r3368702107
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/RootEndpoint.java:
##########
@@ -39,6 +45,10 @@ public class RootEndpoint extends EndpointBase {
private static final Logger LOG =
LoggerFactory.getLogger(RootEndpoint.class);
+ private static final int MAX_DIRECTORY_BUCKETS_LIMIT = 1000;
+ private static final String DEFAULT_S3_REGION = "us-east-1";
+ private static final String S3_EXPRESS_SERVICE = "s3express";
Review Comment:
Can put this to S3Consts.
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/OzoneS3SDKTests.java:
##########
@@ -48,4 +49,12 @@ public MiniOzoneCluster cluster() {
return getCluster();
}
}
+
+ @Nested
+ class ListDirectoryBuckets extends AbstractListDirectoryBucketsV2Tests {
+ @Override
+ public MiniOzoneCluster cluster() {
+ return getCluster();
+ }
+ }
Review Comment:
Please combine this with the existing tests (AbstractS3SDKV2Tests) to
prevent unnecessary spin up of MiniOzoneCluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
