ptlrs commented on code in PR #10419:
URL: https://github.com/apache/ozone/pull/10419#discussion_r3377499365
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -1591,6 +1591,15 @@
If this is empty, no column families are compacted.
</description>
</property>
+ <property>
+ <name>ozone.om.compaction.service.bottommostlevelcompaction</name>
+ <value>0</value>
Review Comment:
While I agree that a string option will be more readable, I have kept it
this way because I want to use the native
`org.rocksdb.CompactRangeOptions.BottommostLevelCompaction#fromRocksId` method.
That method converts an integer to compaction type. There is no method that
RocksDB provides that converts a string to target compaction type.
The reason for keeping it this way is that I want to avoid writing and
updating our custom method as and when rocksdb provides new compaction type
options.
For example, the latest RocksDB already has a `kForceOptimized` option which
our current version doesn't support. I want to avoid creating such manual
mappings and validations in Ozone code.
In case we fail to provide a mapping for some future option, we will not be
able to use that option even if RocksDB supports it.
As a compromise, the helper text provides the relevant information that is
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
