rich7420 commented on PR #10456: URL: https://github.com/apache/ozone/pull/10456#issuecomment-4657518574
Nice work, this reads really cleanly! One thought: a lot of the bring-up here (storage init, port allocation, readiness, shutdown) overlaps with what `MiniOzoneClusterImpl` already does. Did you consider building on it or extracting a shared piece, so the two don't drift apart as SCM/OM init changes? Not a blocker — just curious if it was ruled out for a reason. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
