yandrey321 commented on PR #10439: URL: https://github.com/apache/ozone/pull/10439#issuecomment-4662760048
> > For the hot path the best practice is to limit amount of logging unless its placed for catching specific issue. JIT can do a lot of optimization and simplification/reducing amount of ifs on the hot path helps with JIT's execution path analysis as well as with low level optimizations. > > If this is a performance improvement, please provide some numbers and describe how to run the benchmarks. > > In Ozone, we use LOG.debug(..) everywhere. Why removing only from BlockOutputStream but not the other classes? in general LOG.debug() is OK when they are not on the hot path and do not do expensive calls for logging params. This PR is a follow up after profiling freon benchmark and removes debug logs inside frames that consumes 5+% of CPU during the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
