adoroszlai commented on PR #10439: URL: https://github.com/apache/ozone/pull/10439#issuecomment-4671863728
> benchmark shows 4% throughput improvement I'm not sure about that, or that a single data point for each scenario is enough to conclude anything. I ran the benchmark with 3 scenarios: - 1. `master` before this change - 2. with this change - 3. `master` before this change with `log4j.threshold=INFO` each 3 times. Results: ``` 1-master/1.log:throughput: 5,629.4 MB/s 1-master/2.log:throughput: 5,997.3 MB/s 1-master/3.log:throughput: 5,570.6 MB/s 2-fix/1.log:throughput: 5,565.2 MB/s 2-fix/2.log:throughput: 5,528.3 MB/s 2-fix/3.log:throughput: 5,710.9 MB/s 3-threshold/1.log:throughput: 5,551.3 MB/s 3-threshold/2.log:throughput: 5,596.5 MB/s 3-threshold/3.log:throughput: 5,667.1 MB/s ``` Unexpectedly `master` has the highest mean throughput, but also the highest variance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
