smengcl commented on PR #10302: URL: https://github.com/apache/ozone/pull/10302#issuecomment-4663219672
> > This is generated using /init command in Claude Code. Using Opus 4.7 xhigh. > > I think using the AGENTS.md using Claude Code /init is not advisable. See [humanlayer.dev/blog/writing-a-good-claude-md](https://www.humanlayer.dev/blog/writing-a-good-claude-md) for the reasoning. > > Since AGENTS.md will be loaded for each session, it is important we get this right (otherwise it might be a regression). I would prefer if the creator can try using the AGENTS.md for a while (to do bug fixes, creating small to large features) and update based on their findings and shortcomings. This would increase the community confidence in these AGENTS.md > > Personally, these are the things I would add: > > * Prefer merging new integration tests with existing integration tests (i.e. avoid creating a new MiniOzoneCluster for every test). > * Prefer to use Ratis utilites (e.g. Ratis Preconditions, etc) and reuse existing functions > * No unnecessary line-wrap (as long it fits the checkstyle max length) > * Add Apache header by default > * Add "HDDS-XXXX" for each commit message (but this requires the agent to know which ticket is assigned to so might be difficult). > * Prefer using existing Ozone related glossary instead of inventing new ones unless necessary (things like "control plane", "materialized", etc) > > PTAL of these links I found, we can research on the Harness engineering best practices > > * [github.blog/ai-and-ml/github-copilot/how-to-write-a-great-agents-md-lessons-from-over-2500-repositories](https://github.blog/ai-and-ml/github-copilot/how-to-write-a-great-agents-md-lessons-from-over-2500-repositories/) > * [openai.com/index/harness-engineering](https://openai.com/index/harness-engineering/) > * [martinfowler.com/articles/harness-engineering.html](https://martinfowler.com/articles/harness-engineering.html) Thanks @ivandika3 for the suggestions. I have pushed a rewrite. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
