adoroszlai commented on code in PR #10480:
URL: https://github.com/apache/ozone/pull/10480#discussion_r3395207081
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/ReconOmMetaManagerTestUtils.java:
##########
@@ -25,9 +25,12 @@
import org.apache.ozone.test.GenericTestUtils;
/**
- * Test Recon Utility methods.
+ * Utility methods for Recon OM metadata manager integration tests.
*/
-public class TestReconOmMetaManagerUtils {
+public final class ReconOmMetaManagerTestUtils {
Review Comment:
```suggestion
final class ReconOmMetaManagerTestUtils {
```
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManagerHA.java:
##########
@@ -144,15 +143,15 @@ public void testReconGetsSnapshotFromLeader() throws
Exception {
ReconTaskControllerImpl reconTaskController =
(ReconTaskControllerImpl)
recon.getReconServer().getReconTaskController();
CompletableFuture<Void> completableFuture =
-
omMetaManagerUtils.waitForEventBufferEmpty(reconTaskController.getEventBuffer());
+
ReconOmMetaManagerTestUtils.waitForEventBufferEmpty(reconTaskController.getEventBuffer());
Review Comment:
Same here, I'd prefer adding `import static`.
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconContainerEndpoint.java:
##########
@@ -121,7 +120,7 @@ public void testContainerEndpointForFSOLayout() throws
Exception {
ReconTaskControllerImpl reconTaskController =
(ReconTaskControllerImpl)
recon.getReconServer().getReconTaskController();
CompletableFuture<Void> completableFuture =
-
omMetaManagerUtils.waitForEventBufferEmpty(reconTaskController.getEventBuffer());
+
ReconOmMetaManagerTestUtils.waitForEventBufferEmpty(reconTaskController.getEventBuffer());
Review Comment:
Let's add `import static` for the two methods (`waitForEventBufferEmpty` and
`waitUntilReconKeyCounts`) to improve readability.
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/ReconOmMetaManagerTestUtils.java:
##########
@@ -36,7 +39,8 @@ public class TestReconOmMetaManagerUtils {
*
* @return CompletableFuture that completes when buffer is empty
*/
- public CompletableFuture<Void> waitForEventBufferEmpty(OMUpdateEventBuffer
eventBuffer) {
+ public static CompletableFuture<Void> waitForEventBufferEmpty(
+ OMUpdateEventBuffer eventBuffer) {
Review Comment:
```suggestion
static CompletableFuture<Void> waitForEventBufferEmpty(OMUpdateEventBuffer
eventBuffer) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
