Gargi-jais11 opened a new pull request, #10533:
URL: https://github.com/apache/ozone/pull/10533
## What changes were proposed in this pull request?
1. Expose `getBucketTagging` / `putBucketTagging` / `deleteBucketTagging` on
Ozone client with version gating.
- `ClientProtocol.java / OzoneManagerProtocol.java `— interface methods
- `OzoneManagerProtocolClientSideTranslatorPB.java` — PB translation
- `RpcClient.java `— getBucketTagging, putBucketTagging, deleteBucketTagging
with S3_BUCKET_TAGGING_API version gate
- `OzoneBucket.java` — public client API
- `OzoneRpcClientTests.java` integration tests:
- testPutBucketTagging (overwrite semantics)
- testGetBucketTagging
- testDeleteBucketTagging
- Parameterized across bucket layouts (LEGACY, FILE_SYSTEM_OPTIMIZED,
OBJECT_STORE)
2. **nit:**
If we could introduce a base class for bucket tagging, or make delete
request to derive put request.
the duplication between `S3PutBucketTaggingRequest` and
`S3DeleteBucketTaggingRequest`
[Discussion
link](https://github.com/apache/ozone/pull/10498#discussion_r3418734551)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15511
## How was this patch tested?
Added unit tests for 'OzoneRpcClientTests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
