chihsuan commented on PR #10540: URL: https://github.com/apache/ozone/pull/10540#issuecomment-4756228068
Thanks @chungen0126 for the review! My reading was that the config change is only the **workaround** mentioned in the ticket, and the actual goal of HDDS-15327 is to fix the root cause. That's why this PR goes after the proactive-clear path. cc @Jojochuang since you filed this, could you confirm the intended scope of HDDS-15327? 🙏 Is it the proactive-clear fix this PR implements, or just bumping the default `event.timeout` as a workaround, with the real fix tracked under a new design-doc ticket? Happy either way. Just for context, this PR reuses the exact command-status feedback path that `deleteBlocksCommand` already uses, with no Protobuf/wire change, and degrades gracefully against mixed old/new SCM and DN. That said, I agree this touches a sensitive, larger area. Happy to write up a more details doc and discuss the scope further in the Jira so we align before landing anything. Thanks! 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
