spacemonkd commented on code in PR #10426:
URL: https://github.com/apache/ozone/pull/10426#discussion_r3450159427
##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/AbstractTestStorageDistributionEndpoint.java:
##########
@@ -313,8 +313,8 @@ protected boolean verifyPendingDeletionAfterKeyDeletionDn()
{
StringBuilder urlBuilder = new StringBuilder();
urlBuilder.append(getReconWebAddress(conf)).append(PENDING_DELETION_ENDPOINT).append("?component=dn");
String response = TestReconEndpointUtil.makeHttpCall(conf, urlBuilder);
- DataNodeMetricsServiceResponse pendingDeletion =
- MAPPER.readValue(response, DataNodeMetricsServiceResponse.class);
+ DataNodeMetricsCompleteResponse pendingDeletion =
Review Comment:
Do you think there can be a race condition where collection hasn't finished
when the test calls, as a result it gets `DataNodeMetricsProgressResponse`?
Then this would possibly be flaky. It might be better to either:
- retry until status is FINISHED
- or assert on the JSON status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
