spacemonkd commented on code in PR #10426: URL: https://github.com/apache/ozone/pull/10426#discussion_r3450170454
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/DataNodeMetricsCompleteResponse.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.api.types; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonProperty; +import java.util.List; +import org.apache.hadoop.ozone.recon.api.DataNodeMetricsService; + +/** + * Response returned when metrics collection is complete. + * Includes the metric payload fields. + */ +@JsonInclude(JsonInclude.Include.NON_NULL) +public class DataNodeMetricsCompleteResponse { + + @JsonProperty("status") + private final DataNodeMetricsService.MetricCollectionStatus status; + + @JsonProperty("totalNodesQueried") + private final int totalNodesQueried; + + @JsonProperty("totalNodeQueriesFailed") + private final long totalNodeQueryFailures; + + @JsonProperty("totalPendingDeletionSize") + private final Long totalPendingDeletionSize; + + @JsonProperty("pendingDeletionPerDataNode") + private final List<DatanodePendingDeletionMetrics> pendingDeletionPerDataNode; Review Comment: Since the annotation only includes NON_NULL fields, is it possible that this can get omitted? I feel like the complete response should always have all fields, so it might be better to initialize this to an empty list, unless we are okay with having missing fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
