errose28 commented on code in PR #10543:
URL: https://github.com/apache/ozone/pull/10543#discussion_r3461576731
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/server/TestSCMClientProtocolServer.java:
##########
@@ -62,17 +69,16 @@
* servicing commands from the scm client.
*/
public class TestSCMClientProtocolServer {
- private SCMClientProtocolServer server;
- private StorageContainerManager scm;
- private StorageContainerLocationProtocolServerSideTranslatorPB service;
- private SCMSafeModeManager mockSafeModeManager;
-
- @BeforeEach
- void setUp(@TempDir File testDir) throws Exception {
+ private static SCMClientProtocolServer server;
Review Comment:
`scm` is still being stopped after each test. Looks like that should be
moved to an `AfterAll`, although it happens to work as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
