errose28 commented on code in PR #10543:
URL: https://github.com/apache/ozone/pull/10543#discussion_r3461580187
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1150,15 +1149,19 @@ public ReplicationManagerReport
getReplicationManagerReport() {
return scm.getReplicationManager().getContainerReport();
}
+ /*
+ * This command is deprecated and is retained for backward compatibility. It
no longer finalizes SCM
+ * as the process is driven from OM which will trigger the SCM finalize
process.
+ */
@Override
@Deprecated
- public StatusAndMessages finalizeScmUpgrade(String upgradeClientID) throws
- IOException {
- if (!scm.getVersionManager().needsFinalization()) {
- return new StatusAndMessages(ALREADY_FINALIZED, Collections.emptyList());
- }
- finalizeUpgrade();
- return new StatusAndMessages(STARTING_FINALIZATION,
Collections.emptyList());
+ public StatusAndMessages finalizeScmUpgrade(String upgradeClientID) {
+ // This command is kept only for legacy upgrade scripts which would have
first finalized SCM and then
+ // made a call to OM to finalize it. The new flow, is that a single call
to OM triggers the finalization process.
+ // The legacy OM command now calls the new one and correctly starts the
flow, so this command has become a
+ // noop. Regardless of whether SCM is finalized or not, we return
ALREADY_FINALIZED to allow nay scripts to move
Review Comment:
nit. Typo. Only need to address if pushing another commit already.
```suggestion
// noop. Regardless of whether SCM is finalized or not, we return
ALREADY_FINALIZED to allow any scripts to move
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
