chihsuan commented on code in PR #10540:
URL: https://github.com/apache/ozone/pull/10540#discussion_r3587259541
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java:
##########
@@ -276,7 +281,21 @@ private void addToQueue(AbstractReplicationTask task) {
}
queuedCounter.get(task.getMetricName()).incrementAndGet();
executor.execute(new TaskRunner(task));
+ } else {
+ // Duplicate: an identical task is already in-flight; the in-flight copy
will report the real
+ // outcome, so drain this command's PENDING entry now to avoid a
status-map leak.
+ updateCommandStatus(task, CommandStatus::markAsExecuted);
Review Comment:
Thanks for raising this. I revisited the trade-off and kept the duplicates
as `EXECUTED` since the equivalent work is still running. `FAILED` could cause
a resend/drop loop. The failure-after-duplicate case remains a documented
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
