dnskr opened a new pull request, #47:
URL: https://github.com/apache/ozone-helm-charts/pull/47
## What changes were proposed in this pull request?
1. Deleted redundant new lines in env variables template:
- Deleted commented env variable
`OZONE-SITE.XML_ozone.scm.skip.bootstrap.validation`
- Added newline removal to `include` function call.
Before
```yaml
env:
- name: OZONE-SITE.XML_hdds.datanode.dir
value: /data/storage
- name: OZONE-SITE.XML_ozone.scm.datanode.id.dir
value: /data/metadata
- name: OZONE-SITE.XML_ozone.metadata.dirs
value: /data/metadata
- name: OZONE-SITE.XML_ozone.scm.ratis.enable
value: "true"
- name: OZONE-SITE.XML_ozone.scm.service.ids
value: cluster1
- name: OZONE-SITE.XML_ozone.scm.nodes.cluster1
value: ozone-scm-0
- name: OZONE-SITE.XML_ozone.scm.address.cluster1.ozone-scm-0
value:
ozone-scm-0.ozone-scm-headless.default.svc.cluster.local
```
After
```yaml
env:
- name: OZONE-SITE.XML_hdds.datanode.dir
value: /data/storage
- name: OZONE-SITE.XML_ozone.scm.datanode.id.dir
value: /data/metadata
- name: OZONE-SITE.XML_ozone.metadata.dirs
value: /data/metadata
- name: OZONE-SITE.XML_ozone.scm.ratis.enable
value: "true"
- name: OZONE-SITE.XML_ozone.scm.service.ids
value: cluster1
- name: OZONE-SITE.XML_ozone.scm.nodes.cluster1
value: ozone-scm-0
- name: OZONE-SITE.XML_ozone.scm.address.cluster1.ozone-scm-0
value:
ozone-scm-0.ozone-scm-headless.default.svc.cluster.local
```
2. Deleted unused code from `_helpers.tpl`.
3. Deleted redundant space `emptyDir: { }` -> `emptyDir: {}`.
4. Added missing new line at the end of template files.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15905
## How was this patch tested?
Render the chart templates:
```shell
helm template ozone charts/ozone --set recon.enabled=true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]