Tejaskriya commented on code in PR #47:
URL: https://github.com/apache/ozone-helm-charts/pull/47#discussion_r3703497248
##########
charts/ozone/templates/_helpers.tpl:
##########
@@ -104,38 +84,6 @@ app.kubernetes.io/instance: {{ .Release.Name }}
{{- $nodes | join ","}}
{{- end }}
-{{/* List of decommission scm nodes */}}
-{{- define "ozone.scm.decommissioned.nodes" -}}
Review Comment:
This variable was created for adding graceful HA support for scm, similar to
how it's done for OM: when we scale down, decommissioning should be triggered.
This was a gap left behind in the HA implementation.
I would suggest not removing it, but if you do remove it please add a note
referencing this in
[HDDS-16075](https://issues.apache.org/jira/browse/HDDS-16075)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
