ArafatKhan2198 commented on PR #10539: URL: https://github.com/apache/ozone/pull/10539#issuecomment-5031308458
Thanks for updating the patch and adding SDK v1/v2 coverage. I think the current implementation is too broad and should be discussed before merge. Returning here allows every `x-amz-*` header to be injected after the URL is signed. AWS’s presigned URL documentation requires added `x-amz-*` headers to appear in `X-Amz-SignedHeaders`. This is particularly risky for headers such as `x-amz-copy-source`, which changes Ozone’s PUT operation into COPY_OBJECT. Could we either retain the existing validation or scope the compatibility exception specifically to `x-amz-acl`, with a negative test for other semantic headers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
